Fix erofs build failures from incomplete file_contexts entries #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add validation and repair logic for file_contexts entries that may be missing SELinux contexts from gen_file_contexts tool. This fixes the "invalid file type" errors during erofs/ext4 image building. - Add default SELinux contexts based on partition type (vendor_file for odm/vendor, system_file for system/product) - Validate file_contexts entries and add missing contexts automatically - Update lost+found entry generation with fallback to default context - Ensures all file_contexts lines have proper format: <path> <selinux_context> Co-authored-by: EduardoA3677 <82284031+EduardoA3677@users.noreply.github.com>
- Remove redundant case branches for product/system (use default) - Clarify comment about empty line handling in awk script Co-authored-by: EduardoA3677 <82284031+EduardoA3677@users.noreply.github.com>
- Simplify awk condition using else clause for better readability - Use more robust awk-based extraction for lost_found_ctx - Ensure extraction only succeeds when valid second field exists Co-authored-by: EduardoA3677 <82284031+EduardoA3677@users.noreply.github.com>
- Add explicit 'next' statement to skip empty lines - Update comments to accurately reflect behavior - Preserve extra fields for compatibility with extended formats Co-authored-by: EduardoA3677 <82284031+EduardoA3677@users.noreply.github.com>
- Skip comment lines starting with # in file_contexts validation - Find first valid line with 2+ fields for context extraction (not just first line) - Ensure lost+found context is extracted from a valid entry Co-authored-by: EduardoA3677 <82284031+EduardoA3677@users.noreply.github.com>
- Both awk scripts now use the same pattern for detecting comments - Improves code consistency and maintainability Co-authored-by: EduardoA3677 <82284031+EduardoA3677@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix build error related to erofs file contexts
Fix erofs build failures from incomplete file_contexts entries
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gen_file_contextsgenerates entries with only paths, missing SELinux contexts. mkfs.erofs rejects these as "invalid file type", causing odm/product/system partition builds to fail.Changes
Validation layer: Added awk script to detect and repair incomplete file_contexts entries by appending partition-appropriate default contexts (
vendor_filefor odm/vendor,system_filefor others)Robust context extraction: Changed lost+found entry generation from using first line to finding first valid non-comment line with context field, with fallback to default
Comment/empty line handling: Explicitly skip comments and empty lines to prevent malformed entries
The fix ensures all file_contexts entries conform to
<path> <selinux_context>format before image creation.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.