Skip to content

Conversation

Copy link

Copilot AI commented Dec 30, 2025

CI builds were failing at artifact upload because DEBUG_BUILD mode skips ZIP creation, leaving out/*.zip empty.

Changes

  • Modified scripts/repack_rom.sh to always create the flashable ZIP when running in CI, regardless of DEBUG_BUILD setting
  • Local debug builds continue to skip ZIP creation for faster iteration
-    if GET_FEAT_STATUS DEBUG_BUILD; then
+    if GET_FEAT_STATUS DEBUG_BUILD && ! IS_GITHUB_ACTIONS; then
Original prompt

Fix zip creatiion SamsungDeviceHealthManagerService.apk
[DONE] Built SamsungDeviceHealthManagerService.apk
[00:10:09] [INFO] Building wallpaper-res.apk
[DONE] Built wallpaper-res.apk
[00:10:10] [INFO] Building DressRoom.apk
[DONE] Built DressRoom.apk
[00:10:26] [INFO] Building SecSettings.apk
[DONE] Built SecSettings.apk
[00:10:48] [] Building odm (erofs)... �\�[OK] (00:00)
[00:10:48] [
] Building product (erofs)... �\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|
[00:11:03] [] Building system (erofs)... �\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�
[00:13:04] [
] Building system_dlkm (erofs)... �\�[OK] (00:00)
[00:13:04] [] Building system_ext (erofs)... �\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�[OK] (00:02)
[00:13:06] [
] Building vendor (erofs)... �\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�/�-�\�|�
[00:13:57] [*] Building vendor_dlkm (erofs)... �\�|�/�-�\�|�/�-�[OK] (00:01)
[00:13:58] [INFO] ROM debug build enabled. Repacked images are available at /home/runner/work/AstroROM/AstroROM/out
[DONE] Build completed for dm2q

| Completed everything |

| Build finished for dm2q |

0s
Run actions/upload-artifact@v4
with:
name: AstroROM-dm2q-42
path: out/.zip
if-no-files-found: error
retention-days: 7
compression-level: 6
overwrite: false
include-hidden-files: false
Error: No files were found with the provided path: out/
.zip. No artifacts will be uploaded.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI self-assigned this Dec 30, 2025
Co-authored-by: Eduardob3677 <212653915+Eduardob3677@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix zip creation for SamsungDeviceHealthManagerService.apk Fix CI artifact upload by creating ZIP in GitHub Actions environments Dec 30, 2025
Copilot AI requested a review from Eduardob3677 December 30, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants