Fix wrapper scripts to handle -J JVM options anywhere in arguments and increase default heap to 6GB #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrapper scripts were failing with "Unrecognized option: -JXmx6144M" because:
-Jprefixed JVM options at all-Joptions at the start of arguments, not at the endChanges
Linux/OSX wrappers:
-Joptions from any position in argument list using bash arraysapktoolArgs+=("$1")andset -- "${apktoolArgs[@]}"-Xmx1024M→-Xmx6144MWindows wrapper:
-Joption parsing loop usingfindstrand substring extraction-JXmx2048M→-Xmx2048M-Xmx1024M→-Xmx6144MWorkflow:
-JXmx6144Mflag (now default)Example
Before:
# Fails with "Unrecognized option: -JXmx6144M" apktool d app.apk -o output -JXmx6144MAfter:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.