Preserve unresolvable resource IDs instead of converting to @null #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a resource reference cannot be resolved (e.g., resources with non-standard package IDs like 0x58), preserve the resource ID in hex format instead of returning "@null". This ensures the reference is not lost and can be properly rebuilt. Also added comprehensive unit tests to verify the fix. Co-authored-by: Eduardob3677 <212653915+Eduardob3677@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix decoding issues in AndroidManifest.xml
Preserve unresolvable resource IDs instead of converting to @null
Dec 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When decoding resources with non-standard package IDs (e.g., 0x58), Apktool logged warnings and replaced unresolvable references with
@null, losing the original resource information needed for rebuilding.Changes
@0x580f0000) when resolution fails, instead of@nullBefore
After
This eliminates spurious warnings while maintaining the ability to round-trip APKs with external or obfuscated resource references.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.