Update chapter-02.md #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0111 1111 1111 1111 + 0000 0000 0000 0001 don't create overflow in 16-bit unsigned representation.
EdmanCoding
added a commit
that referenced
this pull request
May 12, 2025
I guess my solution much more descriptive. And i think it's a little bit confusing for readers like me that studying chapter 5 and don't know about assembly yet to see the answers only in assembly without machine code (which fifth chapter dedicated to). Moreover, looks like there is mistake here: 1. LD R1 #2 2. STR R0 R1 #0 The number of instruction changed to +1, so the xF3FF value that you want to load in R1 is now not in the x3004 like in the original code, but in the x3005 instead. Check my version to see what I'm talking about.
EdmanCoding
pushed a commit
that referenced
this pull request
Jun 8, 2025
Co-authored-by: EdmanCoding (@EdmanCoding) Closes #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0111 1111 1111 1111 + 0000 0000 0000 0001 don't create overflow in 16-bit unsigned representation.