Skip to content

Commit

Permalink
fix change event type
Browse files Browse the repository at this point in the history
  • Loading branch information
yiminghe committed Jun 24, 2015
1 parent 3dc4384 commit 47e9cfb
Show file tree
Hide file tree
Showing 2 changed files with 45 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/renderers/dom/client/eventPlugins/ChangeEventPlugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,7 @@ var ChangeEventPlugin = {
targetID,
nativeEvent
);
event.type = 'change';
EventPropagators.accumulateTwoPhaseDispatches(event);
return event;
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
/**
* Copyright 2013-2015, Facebook, Inc.
* All rights reserved.
*
* This source code is licensed under the BSD-style license found in the
* LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory.
*
* @emails react-core
*/

'use strict';

var mocks = require('mocks');
var React = require('React');

describe('ChangeEventPlugin', function() {
var container;

beforeEach(function() {
container = document.createElement('div');
document.body.appendChild(container);
});

afterEach(function() {
React.unmountComponentAtNode(container);
document.body.removeChild(container);
});

it('should fire change for checkbox input', function() {
var called = 0;

function cb(e) {
called = 1;
expect(e.type).toBe('change');
}

var input = React.render(<input type="checkbox" onChange={cb}/>, container);
console.log(input);
console.log(React.findDOMNode(input));
React.findDOMNode(input).click();
expect(called).toBe(1);
});
});

0 comments on commit 47e9cfb

Please sign in to comment.