Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newest readme #557

Merged
merged 17 commits into from
Mar 31, 2023
Merged

Newest readme #557

merged 17 commits into from
Mar 31, 2023

Conversation

rachelzhang0922
Copy link
Contributor

What this PR does / why we need it:

Will this PR make the community happier?

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

How is this PR tested

  • unit test
  • e2e test
  • other (please specify)

Special notes for your reviewer:

Release note:

Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rachelzhang0922 added some comment, please take a look

@saiyan86
Copy link
Contributor

@rachelzhang0922 still have conflicts. Please resolve.

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.09 🎉

Comparison is base (f3dbb78) 56.25% compared to head (8670865) 56.35%.

❗ Current head 8670865 differs from pull request most recent head 94f28be. Consider uploading reports for the commit 94f28be to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
+ Coverage   56.25%   56.35%   +0.09%     
==========================================
  Files          21       21              
  Lines        2062     2062              
==========================================
+ Hits         1160     1162       +2     
+ Misses        794      792       -2     
  Partials      108      108              

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tomqin93 tomqin93 merged commit 34edd98 into main Mar 31, 2023
@tomqin93 tomqin93 deleted the newest-readme branch March 31, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants