Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update timer2 widget to app-mode (full screen mode) #29

Merged
merged 8 commits into from
Dec 15, 2021

Conversation

offer-shmuely
Copy link
Contributor

No description provided.

@pfeerick
Copy link
Member

pfeerick commented Oct 17, 2021

I've just tried all the updated widgets, and they are working great AFAICT!. Thank you very much for adding this functionality! :)

Would it be possible to also take into account the 320x480 aspect ratio of the NV14 as part of these changes, or perhaps a future PR if that is preferable? Timer2 is basically ok, so can just get duplicated into /sdcard/nv14/WIDGETS/Timer2 as is unless you think something needs changing. Both BattCheck and Batt_A1 have data "off-screen" though.

@pfeerick
Copy link
Member

I think the sizing detection is a little off now... This is outputs/old timer2/new timer2

image
image

@offer-shmuely
Copy link
Contributor Author

please try a different implementation
since it is very simple text arraging, I did a dynamic positioning
let me know if that is better...

if, yes, I will do that for the horus as well

@pfeerick
Copy link
Member

pfeerick commented Oct 19, 2021

That generally looks good on the NV14 regardless of layout. Now it's only the top bar that has gone a bit silly left I think.

image
image

@offer-shmuely
Copy link
Contributor Author

I have more update to the widget, but since I am using now the sizeText(), and since the font is proportional, the size of the font is changing
00:00 take more space then 00:11
do we have monospace fonts? even specialy for numbers?

@offer-shmuely
Copy link
Contributor Author

found a solution to the "danving" digit

@pfeerick
Copy link
Member

pfeerick commented Oct 26, 2021

No dancing digits in sight on TX16S or NV14.

Is timer name/number missing from top-bar widgets intentional (both horus and NV14 targets)?

Also, when timers run beyond zero, (i.e. a countdown from 00:15) I've noticed they jump from 00:00 to -1:59:59 and keep counting (backwards to zero)... is this something we've changed that's causing that?

@offer-shmuely
Copy link
Contributor Author

Is timer name/number missing from top-bar widgets intentional (both horus and NV14 targets)?
yep, there is not place for using today functions

the sizeText() take into calculation to match spares, so on the tiny place,
and there is no small font available
so I removed the time name (you can have all in so tiny space)

@pfeerick
Copy link
Member

Revisiting this now, sorry for the delay. So the old form of this used to at least show -- T# -- in the top bar, and then the time... but the new form omits that as part of the height detection. Do you think you could add that back in (I understand that the name would be too long - just the T# or similar annotation) , so that you don't need to remember which timer countdown is for what?

If you think not, that's fine, and this will be merged as it is.

@offer-shmuely
Copy link
Contributor Author

of course 👍

@pfeerick
Copy link
Member

Perfect! Thank you :)

@pfeerick pfeerick merged commit 3e27d75 into EdgeTX:master Dec 15, 2021
@offer-shmuely offer-shmuely deleted the shmuely/timer2_update_app_mode branch February 1, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants