Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S8R/S6R setup script #113

Merged
merged 25 commits into from
Aug 5, 2023
Merged

Conversation

offer-shmuely
Copy link
Contributor

@offer-shmuely offer-shmuely commented Jul 15, 2023

S8R/S6R setup tool

  • choose the correct version for the accst receivers
  • update script presentation name
  • enter the images (bmp&img) into the script folder
  • rename (for the better) the names of the fields
  • reorder the fields to be more consistent
  • add simulator mode for debugging

Resolves #74

Note:
I know that on regular basis we prefer to keep other company script outside with links, so the original developer of the script will not be bind to edgeTx version, but in FrSky case I feel it is not the same

  1. the script have openTX license
  2. FrSky have couple of script and it hard for the user to choose the correct one
  3. the fields have very bad name, that make the use of the gyro intimidating
  4. FrSky did not develop the script for the accst receivers from 2020-07-06, and it does not like they are going to give a better service to it's client on this area

@offer-shmuely
Copy link
Contributor Author

old

image

new
image

image

image

@offer-shmuely offer-shmuely mentioned this pull request Jul 15, 2023
@pfeerick
Copy link
Member

I have no issue with this being added, particularly when it's basically abandon-ware, and someone is willing to support/improve it. It doesn't hurt that I have an SxR or two 😆

@offer-shmuely
Copy link
Contributor Author

abandon-ware? Ha ha
You learn new things every day😀
Can you take a look that text is clear?

@offer-shmuely
Copy link
Contributor Author

adding @JimB40
is that look better?

image
image

@JimB40
Copy link
Contributor

JimB40 commented Jul 17, 2023

Yep it is. My second name is "Whitespace" ;)
To be all good looking move S8R/S6R in header same amount px as content, making progres bar narrower.
Text/gfx modules without whitespaces (margins/paddings) are main OpenTX devs design sin. :)

@offer-shmuely
Copy link
Contributor Author

like this?

image

oshmuely added 2 commits July 18, 2023 02:19
@pfeerick
Copy link
Member

pfeerick commented Jul 30, 2023

This looks and seems to be working great. I'm fine with merging this as is, but thought I'd ask beforehand:

I finally realised why sometimes why it didn't before when you press enter... you need to wait for the values to update onscreen before it will let you continue. Something worth mentioning onscreen somehow?

@offer-shmuely
Copy link
Contributor Author

Do you mean in setup, or calibrate?

@pfeerick
Copy link
Member

pfeerick commented Jul 30, 2023

Sorry, for calibrate... you need to wait for the values to update before it lets you move to the next step... which always confused me with the original version as seemed to be unresponsive when you pressed enter at some times, and responsive at others.

@offer-shmuely
Copy link
Contributor Author

Ya, i had this issues in the past as well,
Took a long time to understand the logic
I will take the challenge and I will search a way to give visual indication

@pfeerick
Copy link
Member

The simplest option would just be a prompt (i.e. "Wait for the values to update before moving to next step" or words to that effect).

Or maybe some way of storing the values from step to step, and then they can change color as they update... i.e. when you press enter, they get reset to red, and then as the new values come in, they would sequentially turn green (since they seem to update in sequence)... just an idea?

@offer-shmuely
Copy link
Contributor Author

added colorful indication (thanks to peter on the suggestion)

image

@offer-shmuely
Copy link
Contributor Author

now with:

  • indication bars in correct side
  • shades

image

@pfeerick
Copy link
Member

pfeerick commented Aug 5, 2023

LGTM... thank you for those final hopefully beneficial to others quality of life touches! :)

@pfeerick pfeerick merged commit 5036de3 into EdgeTX:master Aug 5, 2023
@Jim7695
Copy link

Jim7695 commented Nov 10, 2023

HI Guys - I like the look of this new script. Really nice work. I have a problem maybe you can assist with. I recently installed a FRSKY RB30+ redundant bus module in a new plane. While trying to execute the Parameter Set Script, using my RadioMaster TX16S, the script opened, but no data was received. Currently using Edge TX 2.9.1. I rolled my firmware back to 2.8.5 and the script worked. Any thoughts. Thanks. Jim

@3djc
Copy link
Collaborator

3djc commented Nov 10, 2023

And what is the point exactly of mentioning that here when you have opened an issue ?

@Jim7695
Copy link

Jim7695 commented Nov 10, 2023 via email

@pfeerick
Copy link
Member

This really isn't the place to ask that question, since it's not related to the SxR script plus this PR is closed. Best to wait to see if anyone can respond in EdgeTX/edgetx#4297 You're somewhat lucky the scripts even work, since they are probably not tested by Frsky to work with EdgeTX at all.

Can you link in that issue to where you got the scripts from, and double check if they are the latest version - as depending on where you go on the frsky site, you may not actually have the latest version. Going from this older OpenTX issue, it seems they were somewhat flakely even on OpenTX.

@Jim7695
Copy link

Jim7695 commented Nov 10, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S6R/S8R scripts
6 participants