Sam/enable private requests #5917
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
samholmes
force-pushed
the
sam/enable-private-requests
branch
2 times, most recently
from
8385130 to
0423d71
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
The title "Nym Mixnet" violates the leftmost 1rem margin requirement. There is also too much space >1rem between that title and the paragraph below. I realize a lot of this is legacy code or derived from legacy code, but for such simple components, please rewire stylings and component structure to fit our current conventions and standards. |
| const getStyles = cacheStyles((theme: Theme) => ({ | ||
| instructionArea: { | ||
| backgroundColor: theme.settingsRowSubHeader, | ||
| padding: theme.rem(1) |
There was a problem hiding this comment.
NEVER bake full margins into new named components. This breaks composability design patterns of UI4.
Per our design rules, all elements should be 0.5/0.5 spaced for 99% of cases.
Looking at the screenshot it actually looks like there's too much space surrounding this text
There was a problem hiding this comment.
Using the defined EdgeText components takes care of this for you
| <View style={styles.instructionArea}> | ||
| <UnscaledText style={styles.instructionText}>{label}</UnscaledText> | ||
| </View> |
There was a problem hiding this comment.
This should be a
<Paragraph>
<SmallText>
</SmallText>
</Paragraph>
There was a problem hiding this comment.
If the above doesn't work, those components Paragraph and SmallText need to be fixed
samholmes
force-pushed
the
sam/enable-private-requests
branch
from
d10ce90 to
3a6e77f
Compare
Add MaybePrivateNetworkingSetting component that allows users to
configure network privacy options per currency. The setting uses an
enum field ('none' | 'nym') for forward compatibility with future
privacy options like Tor.
The component follows the existing 'Maybe' pattern and will only
render for currency plugins that include networkPrivacy in their
defaultSettings.
Add axelar, coreum, cosmoshub, osmosis, thorchainrune, and thorchainrunestagenet to CURRENCY_SETTINGS_KEYS so they appear in the Asset Settings scene.
samholmes
force-pushed
the
sam/enable-private-requests
branch
from
3a6e77f to
4ad531d
Compare
Add dedicated Privacy Settings scene accessible from Settings Options section. The scene displays a NYM Mixnet section with explanation text and toggle switches for each currency that supports network privacy settings. Users can enable/disable NYM Mixnet privacy per currency. - Export asPrivateNetworkingSetting cleaner for reuse - Create PrivacySettingsScene with currency toggle rows - Add privacySettings route to navigation - Register scene in Main.tsx with ifLoggedIn wrapper - Add Privacy Settings navigation row as first item in Options section - Add locale strings for privacy settings and NYM Mixnet description
This is to support the new edge-core-js BundleHTTPServer architecture.
samholmes
force-pushed
the
sam/enable-private-requests
branch
from
4ad531d to
8de34cd
Compare
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Medium Risk
Enables a new networking/privacy mode and upgrades core/currency dependencies, which could affect request routing, performance, and transaction/balance reliability across supported plugins.
Overview
Adds a new Privacy Settings flow to enable/disable Nym Mixnet network privacy per supported currency plugin, surfaced both in each
CurrencySettingsSceneand via a dedicatedPrivacySettingsSceneaccessible from the main Settings menu and wired into navigation/types.Updates dependencies to
edge-core-js@2.41.0(bringing in@nymproject/mix-fetch) plus related currency plugins, expandsCURRENCY_SETTINGS_KEYSto include many Cosmos/EVM networks, and adjusts web dev server headers for cross-origin isolation (SharedArrayBuffer) needed by mixnet web workers; includes small TS/ESLint cleanups and snapshot/localization updates.Written by Cursor Bugbot for commit 8de34cd. This will update automatically on new commits. Configure here.