Skip to content

Add msw with rates server snapshots #5611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

peachbits
Copy link
Contributor

@peachbits peachbits commented Jun 3, 2025

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

@peachbits peachbits enabled auto-merge June 4, 2025 21:37
@samholmes
Copy link
Contributor

The maintainer updated https://www.npmjs.com/package/msw-snapshot so patch-package may not be needed if you can confirm it's included

There are two snapshots because there are two rates servers and both need to be accounted for.

Right now, this only adds snapshots for the rates servers. To add them globally across all tests, we can update the following fields in jest.config.js:

setupFilesAfterEnv: ['./src/__mocks__/server.ts'],
 testEnvironment: 'node',
Copy link
Contributor

@samholmes samholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I though this was good to go but then I as I was publishing there was a failed tests. I don't know how it ever worked with what jest is telling me.

I've made updates but to no avail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants