Jon/fix/empty-search #5393
Merged
Jon/fix/empty-search #5393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
requested changes
Dec 10, 2024
Comment on lines
63
to
64
| /** Manually control the whether the input appears selected. Visual only, | ||
| * mutually exclusive with the text input's true blur/focus state. */ |
There was a problem hiding this comment.
fixup to the grammar
/** Manually control whether the input appears selected. Visual only; mutually exclusive with the text input's true blur/focus state. */There was a problem hiding this comment.
No, it's correct. ChatGPT also said this was fine the way it was. If you really wanted a semicolon, it would be in place of the period of the first sentence.
Jon-edge
force-pushed
the
jon/fix/empty-search
branch
3 times, most recently
from
d33fcab to
7dd4a5d
Compare
samholmes
approved these changes
Dec 12, 2024
The tappable area was overlapping the X
samholmes
force-pushed
the
jon/fix/empty-search
branch
from
7dd4a5d to
6c51af2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: