Patch RCTFont.mm to fix crash #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements the following PR as a patch to RCTFont.mm. facebook/react-native#22607 This is an attempt at fixing a high count Bugsnag reported crash which has a profile similar to facebook/react-native#13588
swansontec
approved these changes
Mar 4, 2019
There was a problem hiding this comment.
Wow. Ok, yeah, based on the linked discussion this makes sense, but in a really bad way. The cleanup order is all screwed up in native code, so we leak the mutex to keep it alive forever, rather than try to clean it up at all. That will certainly do the trick!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the following PR as a patch to RCTFont.mm.
facebook/react-native#22607
This is an attempt at fixing a high count Bugsnag reported crash which has a profile similar to
facebook/react-native#13588
PR Requirements
If you have made any visual changes to the GUI. Make sure you have: