Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Fixing Camera Stretch#1365

Merged
EddyVerbruggen merged 1 commit into
EddyVerbruggen:masterfrom
murillobrand:fix-camera-stretch
Aug 19, 2019
Merged

Fixing Camera Stretch#1365
EddyVerbruggen merged 1 commit into
EddyVerbruggen:masterfrom
murillobrand:fix-camera-stretch

Conversation

@murillobrand
Copy link
Copy Markdown
Contributor

This should solve the problem described at #720
Tested on Android 9

@EddyVerbruggen EddyVerbruggen merged commit 1db0360 into EddyVerbruggen:master Aug 19, 2019
@EddyVerbruggen EddyVerbruggen added this to the 9.1.0 milestone Aug 19, 2019
@EddyVerbruggen
Copy link
Copy Markdown
Owner

@murillobrand This seems to work really well, thanks a lot!

I currently run into issues on Android because of the SDK bumps in #1364 so I can't release the new version yet. But I aim to do it one of these days.

EddyVerbruggen added a commit that referenced this pull request Aug 27, 2019
@EddyVerbruggen
Copy link
Copy Markdown
Owner

FYI In 9.1.1 I'm updating this logic a little to make sure the entire viewport is covered by the camera view, because IMO it looks better than cropping the image.

@murillobrand
Copy link
Copy Markdown
Contributor Author

No problem.
Yeah, this way is really better. I didn't thought about this case as I was using a squared view.
Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants