Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Added support for inverse barcodes#1360

Merged
EddyVerbruggen merged 1 commit into
EddyVerbruggen:masterfrom
zalesak:zalesak-inverse-code-pr
Aug 15, 2019
Merged

Added support for inverse barcodes#1360
EddyVerbruggen merged 1 commit into
EddyVerbruggen:masterfrom
zalesak:zalesak-inverse-code-pr

Conversation

@zalesak
Copy link
Copy Markdown

@zalesak zalesak commented Aug 15, 2019

No description provided.

EddyVerbruggen
EddyVerbruggen reviewed Aug 15, 2019
View reviewed changes
Comment thread src/mlkit/barcodescanning/index.d.ts
x: number;
y: number;
},
};
Copy link
Copy Markdown
Owner

@EddyVerbruggen EddyVerbruggen Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, good catch!

@EddyVerbruggen EddyVerbruggen added this to the 9.1.0 milestone Aug 15, 2019
@EddyVerbruggen EddyVerbruggen merged commit d8f6632 into EddyVerbruggen:master Aug 15, 2019
@EddyVerbruggen
Copy link
Copy Markdown
Owner

EddyVerbruggen commented Aug 15, 2019

Really impressive stuff!

Do you perhaps have an example of an inverse barcode you tested your implementation with? I'd love to give it a spin.

@zalesak
Copy link
Copy Markdown
Author

zalesak commented Aug 19, 2019

Hi Eddy, sorry for late response.
Unfortunately, I have just specimen from drugs packages, from customers. I can`t publish it wide. But in principle, solution just inverse picture before sending it to ML KIT so it will work with every inverse barcode.
We are using it on 2D matrix and QR Codes.

@EddyVerbruggen
Copy link
Copy Markdown
Owner

EddyVerbruggen commented Aug 19, 2019

OK, thanks for the reply. Then I'm just going to assume it works ;)

@zalesak
Copy link
Copy Markdown
Author

zalesak commented Aug 19, 2019 •
edited
Loading

You can find inverted qrcode on google or just invert image in bitmap editor and try it :) e.g.
https://community.coreldraw.com/resized-image/__size/680x1000/__key/CommunityServer.Discussions.Components.Files/544/6330.Untitled_2D00_1.jpg

EddyVerbruggen added a commit that referenced this pull request Aug 19, 2019
@EddyVerbruggen
Added support for inverse barcodes #1360 (fixed MLKit on Android no l…
fbd2d63 
…onger processing more than 4 frames)
EddyVerbruggen added a commit that referenced this pull request Aug 19, 2019
@EddyVerbruggen
Added support for inverse barcodes #1360 (added the property to the d…
72a40f0 
…emo, just for show)
EddyVerbruggen added a commit that referenced this pull request Aug 19, 2019
@EddyVerbruggen
Added support for inverse barcodes #1360 (doc)
a748f64
@murillobrand
Copy link
Copy Markdown
Contributor

murillobrand commented Aug 28, 2019

Hey guys o/
I'm having problems with this. Seems like the java code is not being included in the build...
I got an exception:
TypeError: Cannot read property 'BitmapUtil' of undefined

I just update to the latest release of nativescript-plugin-firebase, removed platform's folders and everything.

Any idea of what is happening? @EddyVerbruggen @zalesak

@EddyVerbruggen EddyVerbruggen modified the milestones: 9.1.0, 9.1.2 Aug 28, 2019
EddyVerbruggen added a commit that referenced this pull request Aug 28, 2019
@EddyVerbruggen
Added support for inverse barcodes #1360
6fe0862
@EddyVerbruggen
Copy link
Copy Markdown
Owner

EddyVerbruggen commented Aug 28, 2019

@murillobrand You're spot on. Let me release 9.1.2 today, with a rebuilt jar. Thanks!

@EddyVerbruggen EddyVerbruggen modified the milestones: 9.1.2, 9.2.0 Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@EddyVerbruggen EddyVerbruggen EddyVerbruggen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Android enhancement Firebase: ML Kit iOS

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@zalesak @EddyVerbruggen @murillobrand