4.0.0 - Foreground dispatch can only be enabled when your activity is…

… resumed #39
EddyVerbruggen · Jul 2, 2019 · a8d18da · a8d18da
1 parent 67709c5
commit a8d18da
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/src/nfc.android.ts b/src/nfc.android.ts
@@ -256,6 +256,7 @@ export class Nfc implements NfcApi {
   private intentFilters: any;
   private techLists: any;
   private static firstInstance = true;
+  private started = false;
 
   constructor() {
     this.intentFilters = [];
@@ -290,6 +291,7 @@ export class Nfc implements NfcApi {
       application.android.on(application.AndroidApplication.activityResumedEvent, (args: application.AndroidActivityEventData) => {
         let resumingNfcAdapter = android.nfc.NfcAdapter.getDefaultAdapter(args.activity);
         if (resumingNfcAdapter !== null && !args.activity.isFinishing()) {
+          this.started = true;
           resumingNfcAdapter.enableForegroundDispatch(args.activity, this.pendingIntent, this.intentFilters, this.techLists);
           // handle any pending intent
           nfcIntentHandler.parseMessage();
@@ -302,13 +304,17 @@ export class Nfc implements NfcApi {
         nfcIntentHandler.parseMessage();
       });
 
-      // on startup, we want to make sure the adapter is listening
-      let startupNfcAdapter = android.nfc.NfcAdapter.getDefaultAdapter(activity);
-      if (startupNfcAdapter !== null) {
-        startupNfcAdapter.enableForegroundDispatch(activity, this.pendingIntent, this.intentFilters, this.techLists);
-        // handle any pending intent
-        nfcIntentHandler.parseMessage();
-      }
+      // on startup, we want to make sure the adapter is started, but the application must be active first, otherwise it will crash (so simply wrapping it in a timeout)
+      setTimeout(() => {
+        if (!this.started) {
+          let startupNfcAdapter = android.nfc.NfcAdapter.getDefaultAdapter(activity);
+          if (startupNfcAdapter !== null) {
+            startupNfcAdapter.enableForegroundDispatch(activity, this.pendingIntent, this.intentFilters, this.techLists);
+            // handle any pending intent
+            nfcIntentHandler.parseMessage();
+          }
+        }
+      }, 3000);
     }
   }
 

diff --git a/src/package.json b/src/package.json
@@ -1,6 +1,6 @@
 {
   "name": "nativescript-nfc",
-  "version": "4.0.0",
+  "version": "4.0.1",
   "description": "NFC plugin for your NativeScript app",
   "main": "nfc",
   "typings": "index.d.ts",