Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cordova android 11 and android sdk32/33 fix #1192

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kiwi-x
Copy link

@kiwi-x kiwi-x commented Sep 5, 2022

beside changes to plugin xml you need to have a new flag for pnedingintents for android 13

Markus Weik and others added 2 commits September 5, 2022 12:18
@saggio89
Copy link

saggio89 commented Sep 7, 2022

This is similar to PR #1158 which was merged into master. The only difference is this has an "If" condition. @kiwi-x is this for backward compatibility on old versions of Android?

if (android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.S) {
          pendingIntentValueFLAG = pendingIntentValueFLAG | PendingIntent.FLAG_IMMUTABLE;
}
final PendingIntent pendingIntent = PendingIntent.getBroadcast(cordova.getActivity().getApplicationContext(), 0, receiverIntent, pendingIntentValueFLAG);

@kiwi-x
Copy link
Author

kiwi-x commented Sep 7, 2022

Hello,
yes I think so,
'cause on older Android Version (< Android S) You probably don't have the FLAG_IMMUTABLE flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants