Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Facebook sharing causes android crash, adopted from b6351f9 f… #1126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robvandijk
Copy link

…or 5.6 version

@EddyVerbruggen
Copy link
Owner

Maybe I'm not interpreting this PR correctly, but it seems like this is aimed at the master branch, which already has this change, right?

@robvandijk
Copy link
Author

You're right, my bad. But I'm not familiar how to create a PR against a tag in another repository. Do you first have to create a branch for this in your repository?

@robvandijk
Copy link
Author

So when I try to create the pull request I see this at first:

Screenshot 2020-10-01 at 08 48 01

Note that it now shows a button View pull request. This is what I did before but the pull request is made against master as you noted. If I choose commit ceec42113e0632205419321325f625470a166aa4 instead of base: master in your repository then I see this:

Screenshot 2020-10-01 at 08 48 21

It still shows the changes, but the button View pull request is gone now. Apparently it is not possible to create a pull request like that, there needs to be a branch to create it against.

@robvandijk
Copy link
Author

Hi Eddy, you're probably busy, let me know what I can do to help getting the 5.6.9 version ready.

@justinmichael04
Copy link

Hi Eddie, Robvandijk, running into this issue also. Would be great to get this fix into a 5.6.9 so we can share with Facebook on non Android X.

Much thanks for all your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants