-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Androidx support #1039
Androidx support #1039
Conversation
This helps with API 28. Thanks! |
Please support androidx! My team has no choice but to use it. Thanks :) |
Same here, this plugin has issues with API 28, which is required to upload apps. This PR fixes that, thanks! Please merge :) |
is this already merged with the latest plugin? which versions if its merged? |
published to npm (5.6.6) |
@EddyVerbruggen This update caused my builds to fail with the error |
5.6.6 doesn't work with API 28 and API 27. 5.6.5 works with both (at least build-wise). So I understand, does this mean it would not run on Android X? |
Maybe one of the others can chime in - I've only merged this of the relative high demand and thumbs up I saw. |
Since we are using the AndroidX-branch, I'm happy to chime in. The problem is that you cannot mix plugins depending on the "legacy" android-support with plugins that used AndroidX. If you do, you will see build failures. As such, going from android-support to AndroidX is a breaking change and maybe should have been released as v6.0.0 instead. That way, most users won't be affected since their current version specification of ^5.X.X won't pull the one with AndroidX automatically. What we are doing in order to avoid mixing plugins using Android-Support with ones using AndroidX is to additionally use https://www.npmjs.com/package/cordova-plugin-androidx-adapter in our apps. @DustinBrett and @andersborgabiro could you please test if your build works with v5.6.6 and the adapter plugin added as well? Thanks! |
It builds with this, that should pick 5.6.6:
I don't have anything newer than Android 7 though, so I can't test. |
Note that one can't unpublish a release on npm, but reverting and publishing 5.6.7 is no problem, then release 6.0.0 if there is no alternative. |
Agreed, if unpublishing is not possible, that would be the way to go. Then everyone experiencing build failures due to 5.6.6 should be okay and people requiring AndroidX can use v6.x |
@jachstet-sea OK, this change has been reverted in 5.6.7, and re-applied in 6.0.0. I added a note at the top of the readme and both have been pushed to npm. |
I was not able to pull 5.6.7 recently in npm. Using 5.6.5 for now still. |
@EddyVerbruggen The reason I couldn't get 5.6.7 is I had my package.json pointing directly to this GitHub repo, and this repo doesn't appear to have 5.6.7, whereas npm does. |
Now with 5.6.7 on npm I get another error |
@DustinBrett Sorry for that, I missed a file in the revert. 5.6.8 can now be grabbed from either GitHub or npm. |
This reverts commit e7e977c.
Program type already present: android.support.v4.media.MediaBrowserCompat$CustomActionCallback |
How can I get it to work with Android 12? |
No description provided.