This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
feat: community events to map (#7522) #8093
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* resolved merge conflicts * Update components/map/Clusters.js * Update components/map/EventMarker.js * Update components/map/EventMarker.js * Update models/Profile.js * Suggestions implemented * Update components/map/EventMarker.js --------- Co-authored-by: Eddie Jaoude <eddie@jaoudestudios.com>
github-actions
bot
added
large
|
Reviewpad Report ℹ️ Messages
|
github-actions
bot
added
the
✍ chore: profile
eddiejaoude
removed
the
✍ chore: profile
github-actions
bot
added
the
✍ chore: profile
eddiejaoude
removed
the
✍ chore: profile
Closed
|
Adding a note here for consideration (now or future) Leaflet has an ootb functionality to create layers for data so that folks can quickly toggle the view based on what they want to see. Because we are using an external to leaflet filter, we may or may not want to use this functionality. Here is a link to check it out - happy to open a future issue if we like this direction https://react-leaflet.js.org/docs/example-layers-control/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4789
Finalising PR #7522
Items I am looking at: (I will keep updating this list as I work through the PR)
does the event need a logo?future ideaif virtual use iconfuture ideaif in person use iconfuture ideamap to have toggle for users/events (do events need tags also?)future ideawithLocationfeaturerefactor offset to remove duplication (user/events)future PR