This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
Set preload to false on most links #7356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
medium
|
Reviewpad Report ℹ️ Messages
|
github-actions
bot
added
small
eddiejaoude
reviewed
Jun 3, 2023
| @@ -9,6 +9,7 @@ export default function Link({ children, className, rel, ...restProps }) { | |||
| ? className | |||
| : "text-blue-600 underline decoration-dotted dark:text-blue-500 hover:underline hover:decoration-solid" | |||
| } | |||
| prefetch={false} | |||
There was a problem hiding this comment.
Do we want to have a condition so it only happens on mobile?
There was a problem hiding this comment.
I tried that, but webpack still bundles the code to preload the JavaScript files if the preload is set by a conditional. It is around 700k of JS that gets loaded by the main-XXX chunk of the bundle without preload set to false.
There was a problem hiding this comment.
ouch, ok thank you for clarifying 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed
The additional JavaScript loaded by preload causes performance issues on mobile.
The NextJS configuration of Webpack will not create a separate main chunk for links that are preloaded on desktop only.
This PR will set all links using our Link component to
preload={false}.Check List (Check all the applicable boxes)