Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

data:Jacques-Murray #7338

Merged
merged 3 commits into from
Jun 3, 2023
Merged

data:Jacques-Murray #7338

merged 3 commits into from
Jun 3, 2023

Conversation

Jacques-Murray
Copy link
Member

@Jacques-Murray Jacques-Murray commented Jun 2, 2023

Changes proposed

Created my LinkFree profile.

@github-actions github-actions bot added the medium Pull request with changed lines between 10 and 30 label Jun 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

Welcome @Jacques-Murray! Thank you so much for your first pull request!

@github-actions github-actions bot added waiting-for-reviewers ✍ chore: profile This label will be added on PR with request of Data json addition LGTM labels Jun 2, 2023
@SaraJaoude
Copy link
Member

Thank you for your PR. You may wish to take a look at our Available Icons in Docs again as these are case sensitive.

For example rather than fa-wordpress it should be FaWordpress

@Jacques-Murray
Copy link
Member Author

Thank you. I'll update.

Corrected icons.
@Jacques-Murray
Copy link
Member Author

I've updated the icons and added a new commit to this PR.

Copy link
Member

@Sindhuinti Sindhuinti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉

@Jacques-Murray
Copy link
Member Author

Thank you.

Copy link
Member

@SaraJaoude SaraJaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks for Contributing! 🎉

@kumarsonsoff3 kumarsonsoff3 merged commit af0e0a6 into EddieHubCommunity:main Jun 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition LGTM medium Pull request with changed lines between 10 and 30 waiting-for-reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants