Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Search page cleanup #7288

Merged
merged 2 commits into from
Jun 4, 2023
Merged

Search page cleanup #7288

merged 2 commits into from
Jun 4, 2023

Conversation

dan-mba
Copy link
Member

@dan-mba dan-mba commented May 31, 2023

Changes proposed

Remove unused fields returned from getUsers().
This reduces the data size by ~60kb.
Don't allow links in user cards as they are already a link to the user.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

@github-actions github-actions bot added medium Pull request with changed lines between 10 and 30 waiting-for-reviewers labels May 31, 2023
disallowedElements={['a']}
unwrapDisallowed
className="text-center line-clamp-5"
>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Good spot 👍

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

note: I reformatted the files in vscode

@eddiejaoude eddiejaoude merged commit 374ca1c into main Jun 4, 2023
@eddiejaoude eddiejaoude deleted the search-overfetch branch June 4, 2023 01:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
medium Pull request with changed lines between 10 and 30 waiting-for-reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants