Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

fix: improved management of ISR revalidation #7193

Merged
merged 2 commits into from
May 27, 2023
Merged

fix: improved management of ISR revalidation #7193

merged 2 commits into from
May 27, 2023

Conversation

badrivlog
Copy link
Contributor

@badrivlog badrivlog commented May 26, 2023 •
edited
Loading

Fixes Issue

Closes #7142

Changes proposed

  • add a new isr object in config/app.json to store revalidate values for different pages
  • imported the config file into the getStaticProps function for each page
  • utilized the appropriate revalidate value from the config object in each page's getStaticProps
  • updated the config file with desired revalidate intervals for each page

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@badrivlog
format map page
abd733e
@badrivlog
fix: improved management of ISR revalidation
4124f5e 
* implement improved management of ISR revalidation using configuration file

* format map page
@github-actions github-actions bot added large Pull request with more than 30 changed lines waiting-for-reviewers labels May 26, 2023
@github-actions
Copy link
Contributor

Reviewpad Report

ℹ️ Messages

  • A maintainer will review your pull request soon!

eddiejaoude
eddiejaoude approved these changes May 27, 2023
View reviewed changes
Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@eddiejaoude eddiejaoude merged commit eca93b8 into EddieHubCommunity:main May 27, 2023
@badrivlog badrivlog deleted the isr-revalidate branch May 27, 2023 12:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eddiejaoude eddiejaoude eddiejaoude approved these changes

Assignees
No one assigned
Labels
large Pull request with more than 30 changed lines waiting-for-reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OTHER] Improved management of ISR revalidation intervals using a configuration file
2 participants
@badrivlog @eddiejaoude