Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Fixing Dark mode toggle is not reachable with keyboard navigation #1931

Merged
merged 4 commits into from
Nov 5, 2022
Merged

Fixing Dark mode toggle is not reachable with keyboard navigation #1931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e1c0a4e
Fixing Dark mode toggle is not reachable with keyboard navigation
Oct 8, 2022
b841620
Replacing a tag with the button Issue #1927
Oct 9, 2022
f38ac6c
Replacing a tag with the button Issue #1927
Oct 9, 2022
f20e3a8
Fix margins due to a tag changing to button
Oct 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Components/Navbar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,11 @@
}

.theme--button {
margin-left: 1rem;
border: none;
background-color: transparent;
margin-left: 0.5rem;
cursor: pointer;
margin-right: -0.4rem;
}

@media screen and (max-width: 320px) {
Expand Down
4 changes: 2 additions & 2 deletions src/Components/Navbar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ function Navbar({ items, start, end }) {

<div style={theme}>v{version}</div>

<div className="theme--button">
<button className="theme--button">
{darkTheme
? (
<GetIcons
Expand All @@ -56,7 +56,7 @@ function Navbar({ items, start, end }) {
: (
<GetIcons iconName="sun" onClick={toggleTheme} size={20} />
)}
</div>
</button>
</div>
)
}
Expand Down