Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

added crazydevlegend #1905

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Conversation

crazydevlegend
Copy link
Contributor

@crazydevlegend crazydevlegend commented Oct 5, 2022

Adding my profile...

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions bot added the medium Pull request with changed lines between 10 and 30 label Oct 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

Welcome @crazydevlegend! Thank you so much for your first pull request!

@github-actions github-actions bot added ✍ chore: profile This label will be added on PR with request of Data json addition LGTM labels Oct 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

Thank you for adding/editing your profile. Note this will not be included as part of Hacktoberfest.

@github-actions github-actions bot added the invalid Inappropriate or invalid for Hacktoberfest contributions label Oct 5, 2022
@crazydevlegend
Copy link
Contributor Author

I just wanna know the meaning of invalid tag github-actions bot added to this PR.
@EmmaDawsonDev Can you please review my PR and check if it's all right to merge?

Copy link
Member

@EmmaDawsonDev EmmaDawsonDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your profile looks fine :) The invalid tag was added to mark that it's not included as a hacktoberfest contribution.

@crazydevlegend
Copy link
Contributor Author

Awesome, now what shall i do to make it able to merge, @EmmaDawsonDev ?
or it doesn't have to be merged???

@EmmaDawsonDev
Copy link
Member

Just wait for a second maintainer review. If they have any comments you should get a message about changes, otherwise they'll approve and merge :)

@crazydevlegend
Copy link
Contributor Author

@Panquesito7 can you please review this PR?
It's nothing, but only to add my profile.
and please let me know if it's able to be merged...

Co-authored-by: David Leal <halfpacho@gmail.com>
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks. 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition invalid Inappropriate or invalid for Hacktoberfest contributions LGTM medium Pull request with changed lines between 10 and 30
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants