Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Update README #1871

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Update README #1871

merged 1 commit into from
Oct 12, 2022

Conversation

E-fais
Copy link
Member

@E-fais E-fais commented Oct 3, 2022

changed a sentence which i felt confusing.

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

changed a sentence which i felt confusing.
@github-actions github-actions bot added small Pull request with less than 10 changed lines waiting-for-reviewers labels Oct 3, 2022
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@@ -7,7 +7,7 @@

> **Warning** (2)
>
> Your profile will need to be deployed to appear, we try to collect a few together before deploying
> In order for your profile to appear, it must be deployed, and we try to collect a few profiles before we begin to deploy.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about this? 🙂

Suggested change
> In order for your profile to appear, it must be deployed, and we try to collect a few profiles before we begin to deploy.
> For your profile to appear, it must be deployed. We try to collect a few profiles before we begin to deploy.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me! 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📄 aspect: text undefined ✨ goal: improvement undefined small Pull request with less than 10 changed lines waiting-for-reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants