-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Implement Hover Effect to Clarify Uneditable Links #10348
Conversation
Hey @SohamRoy-01 and @eddiejaoude - in looking back at this issue, I originally approved it thinking it was about the github profile link (which should not be edited as it's connected to your biodrop profile) However, on looking more closely - i see this is about the links page and a user SHOULD be able to edit their added links afaik. This code is fine if we want it, but I'm confused as to why this field is blocked at all. Can anyone update me, am I missing something abotu why I should not be able to edit the url of a link that I have on my profile? |
Because the stats are collected against the url, we have it that the url for the links cannot be changed and therefore are disabled input fields. The issue is meant to show to the user why the url for the link can't be edited |
Ah yes! It had been too long and I wasn't able to get that from the issue convo. Thanks Eddie! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
But I left an inline comment about the message to the user
Co-authored-by: Eddie Jaoude <eddie@jaoudestudios.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
Add Hover Effect for Explaining Uneditable Links
Fixes Issue :-
closes #10215
Closes Issue :- #10215
Changes proposed
Check List (Check all the applicable boxes)
Note to reviewers
I've made adjustments to the code to accommodate specific circumstances. Please review the changes and let me know if anything further is needed. @eddiejaoude