Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

[FEATURE] Add label to the input in "Profile" section #8703

Closed
zaid-ahmad opened this issue Aug 19, 2023 · 9 comments
Closed

[FEATURE] Add label to the input in "Profile" section #8703

zaid-ahmad opened this issue Aug 19, 2023 · 9 comments
Assignees
@ZeeMonk-pixel
Labels
⭐ goal: addition undefined 🔢 points: 2 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)

Comments

@zaid-ahmad
Copy link
Contributor

Description

The dropdown menu below the username input is confusing. I don't know what it's for or what it does. I think it would be helpful if there was a label for it.

Screenshots

image

Additional information

No response
@zaid-ahmad zaid-ahmad added ⭐ goal: addition undefined 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Aug 19, 2023
@github-actions
Copy link
Contributor

To reduce notifications, issues are locked until they are https://github.com/EddieHubCommunity/LinkFree/labels/%F0%9F%8F%81%20status%3A%20ready%20for%20dev and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/LinkFree/blob/main/CONTRIBUTING.md

@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2023
@SaraJaoude SaraJaoude added 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) 🔢 points: 2 undefined and removed 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Aug 28, 2023
@github-actions github-actions bot unlocked this conversation Aug 28, 2023
@github-actions
Copy link
Contributor

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@SaraJaoude
Copy link
Member

Thanks for raising - agreed this can be a bit confusing.

@ZeeMonk-pixel
Copy link
Contributor

Good morning. What label should be there? I can work on this issue if i know what label you'll like to be there. pls assign it to me

@dhruvilmehta
Copy link
Member

I think it's not just about the "Layout" label, we should put the Preview at the side so the user can see how the layout will look like. Because normal users cannot understand "Classic", "Inline" and "Column-2" layout by just seeing the name, they should be able to preview it as well.

@ZeeMonk-pixel
Copy link
Contributor

Oh. Then I guess it should still be up for discussion then.

@dhruvilmehta
Copy link
Member

Screen_recording-2023-08-28_14-21-02.mp4

I have made this kind of preview. See if this can be implemented or not.

@SaraJaoude
Copy link
Member

The label should be called Profile Layout.

@ZeeMonk-pixel as you asked first I will assign this to you. You may wish to consider collaborating with @dhruvilmehta given that they seem to have started work on this already? If you are happy to do this I can add them as an assignee also.

@ZeeMonk-pixel
Copy link
Contributor

ZeeMonk-pixel commented Aug 29, 2023 •
edited
Loading

the preview on the right seems like a new feature, one I think will be wise for the team to discuss before it is implemented. I'll stick to just the label now and an issue to add that new feature can be raised later on.

ZeeMonk-pixel added a commit to ZeeMonk-pixel/BioDrop that referenced this issue Aug 29, 2023
@ZeeMonk-pixel
[FEATURE] Add label to the input in Profile section EddieHubCommunity…
f26902f 
…#8703
@sital002 sital002 mentioned this issue Aug 29, 2023
Merged
6 tasks
eddiejaoude pushed a commit that referenced this issue Aug 29, 2023
@ZeeMonk-pixel
feat: label to the input in profile section #8703 (#8839)
6ada7cd
eddiejaoude pushed a commit that referenced this issue Sep 1, 2023
@ZeeMonk-pixel
fix: use double bang operator to convert value to either true or false (
6f590fa 
#8887)

* [FEATURE] Add label to the input in Profile section #8703

* [BUG] - Incorrect conditional rendering logic to display profile stats #8684
eddiejaoude pushed a commit that referenced this issue Oct 1, 2023
@ZeeMonk-pixel
fix: display more default icons #8421 (#9068)
5794d38 
* [FEATURE] Add label to the input in Profile section #8703

* [BUG] - Incorrect conditional rendering logic to display profile stats #8684

* [FEATURE] Display most popular icons in Search for Icons page
#8421

* fix icons spec test. change default icons from 5 to 20

* check test on  icon.spec.js

* work on icon.spec.js
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ZeeMonk-pixel ZeeMonk-pixel

Labels
⭐ goal: addition undefined 🔢 points: 2 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@eddiejaoude @zaid-ahmad @dhruvilmehta @SaraJaoude @ZeeMonk-pixel