Prevent buffer overflows in decompression #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoco_decompress prevents buffer overflows by returning SIZE_MAX when the input is smaller than expected.
|
That look sensible. However, this should be documented – the proper place is in the gh-pages branch, in sections/api.md. There's a 'render.py' to render the docs. It's a home-grown solution and not very pretty :( I'll merge it anyway, just say if you plan to document it. If not, I will do it (eventually). Also, if you do it, add yourself to authors. |
Ed-von-Schleck
added a commit
that referenced
this pull request
Mar 16, 2015
Prevent buffer overflows in decompression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shoco_decompress prevents buffer overflows by returning SIZE_MAX when
the input is smaller than expected.
This commit fixes #12