Skip to content

Utilisation de l'éditeur de code Monaco pour les champs contenant un langage informatique (Yaml, Bibtex) #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 15, 2023
Merged

Utilisation de l'éditeur de code Monaco pour les champs contenant un langage informatique (Yaml, Bibtex) #727

merged 12 commits into from
Jan 15, 2023

Conversation

thom4parisot
Copy link
Member

@thom4parisot thom4parisot commented Jan 12, 2023 •
edited
Loading

Je n'ai pas réussi à supprimer la gouttière latérale gauche 😞
Et j'avoue que les options sont cryptiques à lire — t'avais des idées et suggestions @Mogztter ?

Métadonnées

image

Profil utilisateur

image

Bibliographie

image

fixes #481

@netlify
Copy link

netlify bot commented Jan 12, 2023 •
edited
Loading

✅ Deploy Preview for stylo-dev ready!

Name Link
🔨 Latest commit 369b79e
🔍 Latest deploy log https://app.netlify.com/sites/stylo-dev/deploys/63c1b7ebd777d40008c37bcb
😎 Deploy Preview https://deploy-preview-727--stylo-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@thom4parisot thom4parisot marked this pull request as ready for review January 12, 2023 19:22
ggrossetie
ggrossetie reviewed Jan 13, 2023
View reviewed changes
front/src/components/Write/providers/monaco/BibtexEditor.jsx
import styles from '../../../field.module.scss'

// Taken from https://github.com/koka-lang/madoko/blob/master/styles/lang/bibtex.json
import languageDefinition from './lang/bibtex.json'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@ggrossetie
Copy link
Collaborator

Je n'ai pas réussi à supprimer la gouttière latérale gauche 😞

C'est quoi la gouttière ?

Et j'avoue que les options sont cryptiques à lire — t'avais des idées et suggestions @Mogztter ?

Comme ça pas vraiment, je vais tester sur la preview pour voir 😉

@ggrossetie
Copy link
Collaborator

La preview ne s'affiche pas:

index-533e9be2.js:161 Uncaught TypeError: Cannot set property createElement of [object Module] which has only a getter
    at Nr (index-533e9be2.js:161:17241)
    at index-533e9be2.js:161:18747

@thom4parisot
Copy link
Member Author

La preview ne s'affiche pas:

index-533e9be2.js:161 Uncaught TypeError: Cannot set property createElement of [object Module] which has only a getter
    at Nr (index-533e9be2.js:161:17241)
    at index-533e9be2.js:161:18747

Ça y'est, corrigé avec 465d5ab

@ggrossetie ggrossetie merged commit 7582938 into master Jan 15, 2023
@ggrossetie ggrossetie deleted the feature/481 branch January 15, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggrossetie ggrossetie ggrossetie left review comments

@antoinentl antoinentl Awaiting requested review from antoinentl

@marviro marviro Awaiting requested review from marviro

@RochDLY RochDLY Awaiting requested review from RochDLY

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Utiliser l'éditeur de texte Monaco pour les zones de texte
2 participants
@thom4parisot @ggrossetie