Skip to content
This repository has been archived by the owner on Mar 8, 2022. It is now read-only.

Remove position-sticky test that isn't agreed upon #69

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

stephenmcgruer
Copy link
Contributor

position-sticky-input-box-gets-focused-after-scroll.html tests
behaviour that isn't widely agreed upon, as I understand it. The
test passes in Chrome only due to an unshipped feature behind
the --experimental-web-platform-features flag, which Chrome
doesn't currently intend to ship either.

position-sticky-input-box-gets-focused-after-scroll.html tests
behaviour that isn't widely agreed upon, as I understand it. The
test passes in Chrome only due to an unshipped feature behind
the `--experimental-web-platform-features` flag, which Chrome
doesn't currently intend to ship either.
@stephenmcgruer
Copy link
Contributor Author

@flackr - can you confirm that this test should be removed? Also, is there an issue I could link to covering it?

@flackr
Copy link

flackr commented Dec 2, 2021

Sure, removing it from compat-2021 makes sense. The behavior is agreed upon in spec but not actually shipped by any browser.

@foolip
Copy link
Collaborator

foolip commented Dec 2, 2021

@flackr can you point to the spec behavior and the runtime feature that covers this? Do you know if any other browser intends to ship this anytime soon? Will it even be safe to ship (for site compat) if it happens far in the future?

@dholbert
Copy link
Contributor

dholbert commented Dec 2, 2021

wpt.fyi link, for convenience: https://wpt.fyi/results/css/css-position/sticky/position-sticky-input-box-gets-focused-after-scroll.html

This test is in a section of the txt file that says # The following tests pass on all three browsers, here, though per WPT.fyi that doesn't seem to be true in this particular case.

Given that Safari, Firefox, and Chrome-in-its-shipping-configuration all fail the test with what seems to be the exact same issue[1], it makes sense to remove this from the compat2021 test set. (Rationale: to the extent that there do exist any webcompat demands around this test's behavior, they would surely be for the interoperably-shipping behavior that causes the test-failure, rather than for the test's expected behavior that nobody ships at the moment).

[1] The test failure in all browsers (including default-configured Chrome) is: Focusing on visible sticky input box should reset the scroll to unshifted sticky position. / expected 0 but got 100

@stephenmcgruer stephenmcgruer merged commit 723f49c into main Dec 6, 2021
foolip added a commit to web-platform-tests/wpt-metadata that referenced this pull request Dec 8, 2021
github-actions bot pushed a commit to web-platform-tests/wpt-metadata that referenced this pull request Dec 8, 2021
@foolip foolip deleted the stephenmcgruer-patch-1 branch February 21, 2022 08:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants