Skip to content

[JTT-514] Big refactoring of EVData #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Dec 13, 2023
Merged

[JTT-514] Big refactoring of EVData #337

merged 23 commits into from
Dec 13, 2023

Conversation

tropxy
Copy link
Contributor

@tropxy tropxy commented Dec 6, 2023

No description provided.

@tropxy tropxy requested a review from shalinnijel2 December 6, 2023 21:37
@tropxy tropxy marked this pull request as draft December 6, 2023 21:38
shalinnijel2
shalinnijel2 suggested changes Dec 9, 2023
View reviewed changes
Copy link
Contributor

@shalinnijel2 shalinnijel2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi André - with some minor changes suggested below I was able to run DIN and -2 sessions ( ac/dc and eim/pnc). Haven't looked at -20 yet. Will run through that tomorrow.

@tropxy tropxy force-pushed the refactor/charging_commands branch from 2e56fe6 to 4ce9039 Compare December 10, 2023 00:03
@tropxy tropxy self-assigned this Dec 11, 2023
@tropxy tropxy marked this pull request as ready for review December 11, 2023 19:12
@tropxy tropxy force-pushed the refactor/charging_commands branch 2 times, most recently from d01040f to d4741ad Compare December 11, 2023 19:56
@tropxy tropxy requested a review from shalinnijel2 December 12, 2023 01:01
shalinnijel2
shalinnijel2 suggested changes Dec 12, 2023
View reviewed changes
tropxy added 20 commits December 12, 2023 17:46
@tropxy
big refactoring on ev data and update of CPD, PreCharge and CurrentDe…
9ba63d7 
…mand in -2
@tropxy
Updated DIN with the new EVData context update
b0dd796
@tropxy
Updated -20 DC Charge Loop
ec88677
@tropxy
added acbt charge loop
961f2d3
@tropxy
fixed -20 state
9f530a1
@tropxy
updated AC and Schedule exchange with new EV data context structure
4e97df6
@tropxy
started adapting the EVSE data as well
c1ecd2d
@tropxy
fixed some typos
717401c
@tropxy
fix data structures for EV Data and din spec
41ae52f
@tropxy
continue fixing the states and added code to get limits on the Charge…
1c74f73 
… Loop based on EV/EVSE session limits
@tropxy
started fixing the tests
a0d9b6f
@tropxy
removed set_precharge and send power limit
c2c7712
@tropxy
updated test
f412a0c
@tropxy
updated din spec states
5e5ecc1
@tropxy
cleaned simulator
0ccecb8
@tropxy
continue fixing tests
009ec1e
@tropxy
fixed more tests
5039562
@tropxy
fixed tests, reformated and refactored
0b13fa9
@tropxy
flaked the code
0461634
@tropxy
reformatted, flaked and rebased
77ae012
@tropxy tropxy force-pushed the refactor/charging_commands branch from 1f7834b to 97b25bd Compare December 12, 2023 17:46
@tropxy tropxy requested a review from shalinnijel2 December 12, 2023 17:47
shalinnijel2
shalinnijel2 previously approved these changes Dec 13, 2023
View reviewed changes
@tropxy tropxy merged commit 42a660c into master Dec 13, 2023
@tropxy tropxy changed the title Big refactoring of EVData [JTT-514] Big refactoring of EVData Dec 13, 2023
@notion-workspace Notion Workspace
Copy link

Refactor of EV/EVSEData in iso15118 to unblock JTT-416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shalinnijel2 shalinnijel2 shalinnijel2 left review comments

Assignees

@tropxy tropxy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tropxy @shalinnijel2