Remove exi dependency #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This a quick summary of the changes in this commit: - py4j dependency is removed from .toml file. It is installed at runtime if required. - Make file is updated to point at main.py in evcc and secc projects. start_evcc.py and start_secc.py are removed - encode_signed_info() and decode_signed_info() methods are removed in the attached jar files. There is a more "unified" encode and decode method that would work for signed_info as well - A singleton is added to exi_codec.py class which would hold on to the passed in exi codec. The class is added to help the to_exi() and from_exi() methods that would request the exicodec to use.
tropxy
requested changes
Feb 15, 2022
tropxy
requested changes
Feb 15, 2022
There was a problem hiding this comment.
Can you also add the logger instantiation to the init.py of the secc and evcc? Check it: https://github.com/SwitchEV/iso15118/blob/rust_exi_codec/iso15118/secc/__init__.py
I noticed that not all log messages were being printed due to the absence of that
tropxy
requested changes
Feb 17, 2022
There was a problem hiding this comment.
Shalin this line needs to be changed
https://github.com/SwitchEV/iso15118/blob/remove_exi_dependency/pyproject.toml#L38
start_secc -> main
I think that is all it is needed to make the Docker work, but please test it with make build and make dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a quick summary of the changes in this commit:
[Update]
Since py4j may have future dependency conflicts with other packages, is for the best to include it in the toml. For the bundle generation targeting any production device of Josev (where we use the rust exi codec) we can strip out py4j as a dependency)