-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement era5 land #21
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, everything works well 🚀
I just left some comments on reorganizing the code and inheriting more.
Ok...Linter fails because of another abstract class thingy, due to |
It would be nice to keep the type hint here though: DATASETS: dict[str, type[dataset_protocol.Dataset]] = { Perhaps use Although I would have thought we can just provide the protocol as type and things should work: https://mypy.readthedocs.io/en/stable/protocols.html#simple-user-defined-protocols Perhaps ECMWFDataset needs to subclass protocol as well... see: https://mypy.readthedocs.io/en/stable/protocols.html#defining-subprotocols-and-subclassing-protocols 🤔 |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these last changes. Let's merge! 🚀
Support ERA5 land dataset in zampy.