-
Notifications
You must be signed in to change notification settings - Fork 389
add extension volar #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add extension volar #436
Conversation
jankeromnes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for this cool addition @OnlyBjarne!
Looking at the repository, I think the extensions are actually inside the extensions directory, which needs to be reflected in a "location" attribute here. Also, publishing a specific "version" and tag ("checkout") is recommended when possible.
Finally, I'm not 100% sure about this one, but looking at the repository's general structure and its scripts, it seems safer to me to add a "prepublish": "yarn compile" to build the entire repository prior to publishing the extensions.
I'll make both adjustments as suggestions in-line, which I can auto-apply before merging, so no extra work required here. 🙌 🌴
|
Hi @jankeromnes, extensions seems still not publish yet, is anything I can do? |
|
Hi @johnsoncodehk! Since you're the extension owner, I think the simplest way to get your extensions published to OpenVSX is to run This uses the same tech as Microsoft's extensions marketplace, so if you already have a publishing setup, you could simply add that You don't need to install or setup anything specific, except that you'll need a token (available from your settings in https://open-vsx.org). That's about it. Please feel free to reach out if you have any questions or bugs, we're happy to help! 😊 |
|
Thanks for your response! I prefer to hand over the release of OpenVSX to this repo, and I am also willing to maintain the Volar release settings of this repo, so in my repo I can focus on solving issues instead of dealing with additional CI and token management. Do I need to adjust my project to accommodate the release here? |
|
Hello, Is the work of publishing open-vsx still going on? |
|
Please send a new PR.
@johnsoncodehk It would be ideal that we don't need this repo anymore. Initially it was used to seed the registry, but now there are many authors doing publishing directly while the registry adopted by all forks of VS Code, i.e. Gitpod, Theia, VSCodium, code-server and so on. Just from Gitpod it is used by 400 thousands of devs. Technically it should be straightforward. You have to get a token and call ovsx publish with it, for instance how RedHat is publishing the java extension: https://github.com/redhat-developer/vscode-java/blob/ff51dbffc30dd23190335c929e9f34ccdf511554/Jenkinsfile#L73-L82 Docs are here: https://github.com/eclipse/openvsx/wiki/Publishing-Extensions |
Co-authored-by: Jan Keromnes <janx@linux.com>
No description provided.