Skip to content

Conversation

@OnlyBjarne
Copy link
Contributor

No description provided.

Copy link
Collaborator

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this cool addition @OnlyBjarne!

Looking at the repository, I think the extensions are actually inside the extensions directory, which needs to be reflected in a "location" attribute here. Also, publishing a specific "version" and tag ("checkout") is recommended when possible.

Finally, I'm not 100% sure about this one, but looking at the repository's general structure and its scripts, it seems safer to me to add a "prepublish": "yarn compile" to build the entire repository prior to publishing the extensions.

I'll make both adjustments as suggestions in-line, which I can auto-apply before merging, so no extra work required here. 🙌 🌴

@johnsoncodehk
Copy link

Hi @jankeromnes, extensions seems still not publish yet, is anything I can do?

@jankeromnes
Copy link
Collaborator

Hi @johnsoncodehk!

Since you're the extension owner, I think the simplest way to get your extensions published to OpenVSX is to run npx ovsx publish from your extensions' repos.

This uses the same tech as Microsoft's extensions marketplace, so if you already have a publishing setup, you could simply add that npx ovsx publish command at the end (e.g. right after vsce publish).

You don't need to install or setup anything specific, except that you'll need a token (available from your settings in https://open-vsx.org). That's about it.

Please feel free to reach out if you have any questions or bugs, we're happy to help! 😊

@johnsoncodehk
Copy link

Thanks for your response! I prefer to hand over the release of OpenVSX to this repo, and I am also willing to maintain the Volar release settings of this repo, so in my repo I can focus on solving issues instead of dealing with additional CI and token management.

Do I need to adjust my project to accommodate the release here?

@yumcc-com
Copy link

Hello, Is the work of publishing open-vsx still going on?

@akosyakov
Copy link
Collaborator

akosyakov commented Oct 30, 2021

Please send a new PR.

Thanks for your response! I prefer to hand over the release of OpenVSX to this repo, and I am also willing to maintain the Volar release settings of this repo, so in my repo I can focus on solving issues instead of dealing with additional CI and token management.

@johnsoncodehk It would be ideal that we don't need this repo anymore. Initially it was used to seed the registry, but now there are many authors doing publishing directly while the registry adopted by all forks of VS Code, i.e. Gitpod, Theia, VSCodium, code-server and so on. Just from Gitpod it is used by 400 thousands of devs. Technically it should be straightforward. You have to get a token and call ovsx publish with it, for instance how RedHat is publishing the java extension: https://github.com/redhat-developer/vscode-java/blob/ff51dbffc30dd23190335c929e9f34ccdf511554/Jenkinsfile#L73-L82 Docs are here: https://github.com/eclipse/openvsx/wiki/Publishing-Extensions

tennox pushed a commit to tennox/publish-extensions that referenced this pull request Jan 21, 2022
Co-authored-by: Jan Keromnes <janx@linux.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants