Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update free-programming-books-he.md #6374

Merged
merged 3 commits into from
Oct 23, 2021

Conversation

shabtaisharon
Copy link
Contributor

@shabtaisharon shabtaisharon commented Oct 22, 2021

What does this PR do?

Add resource(s)

For resources

Description

Why is this valuable (or not)?

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Read our contributing guidelines
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction)

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@davorpa
Copy link
Member

davorpa commented Oct 22, 2021

  • [ x] Add needed indications (PDF, access notes, under construction)

On editing, remember use [x] (without whitespaces) to mark tasklist items, or do it later interactively from details view.

@davorpa davorpa added the waiting for changes PR has been reviewed and changes/suggestions requested label Oct 22, 2021
@shabtaisharon
Copy link
Contributor Author

  • [ x] Add needed indications (PDF, access notes, under construction)

On editing, remember use [x] (without whitespaces) to mark tasklist items, or do it later interactively from details view.

Done!

@shabtaisharon shabtaisharon requested a review from davorpa October 22, 2021 17:08
@davorpa davorpa added 🚀 ready to merge LGTM. Waiting for final approval and removed waiting for changes PR has been reviewed and changes/suggestions requested labels Oct 22, 2021
@eshellman
Copy link
Collaborator

Thanks, and welcome to free-programming-books!

@eshellman eshellman merged commit 0f5a5a6 into EbookFoundation:master Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 ready to merge LGTM. Waiting for final approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants