Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt a Code of Conduct #1701

Merged
merged 3 commits into from
Nov 17, 2015
Merged

Adopt a Code of Conduct #1701

merged 3 commits into from
Nov 17, 2015

Conversation

vhf
Copy link
Member

@vhf vhf commented Nov 12, 2015

I think it's a shame that the second most popular github repository does not have a code of conduct and I intend to fix this. We never needed a code of conduct, we don't want to need a code of conduct and that's why we need a code of conduct.

I submit this as a PR instead of committing directly to master because I want to allow some debate on this issue. I will merge this PR in a week or so, if there is no good case against it.

@vhf vhf added enhancement 👥 discussion This Repo is guided by its community! Let's talk! labels Nov 12, 2015
@onebree
Copy link
Contributor

onebree commented Nov 12, 2015

Although this repo is just a set of links, I think a COC is a great idea. Like you said, this is a popular repo, that is often hit by spammers. While a COC will not prevent spammers, at least rules are still implemented.

  1. Why did you choose to adopt this particular COC?
  2. The rendered Markdown treats each LOC as a new line of text. I think the 2 spaces following each line causes this. If the COC becomes a markdown file, I think the text should flow as expected on a webpage.

@vhf
Copy link
Member Author

vhf commented Nov 12, 2015

Thanks for your input.

  1. I had a look at the most popular COCs and chose this one. This resource helped me. This PR is also here to discuss if the proposed COC is the one we should adopt. I don't have strong feelings towards this particular COC and am open to dialogue.
  2. Fixed - thanks!

@onebree
Copy link
Contributor

onebree commented Nov 12, 2015

  1. I do not have a strong opinion towards any one COC, either. Honestly, I did not take the time to read every line of this one, because, like mentioned before, we are just a repo of links. COC really comes into play during conversations, which are actually handled well already.
  2. You did not need to write 1 line per paragraph. Markdown renders fine if a line (but mid-paragraph) ends with 0-1 spaces. Otherwise, it is treated as a line break. But hey, whatever :-) Still looks good.

vhf added 2 commits November 12, 2015 22:19
I think it's a shame that the second most popular github repository does not have a code of conduct and I intend to fix this. We never needed a code of conduct, we don't want to need a code of conduct and that's why we need a code of conduct.

I submit this as a PR instead of commiting directly to master because I want to allow some debate on this issue. I will merge this PR in a week or so, if there is no good case against it.
@vhf vhf force-pushed the add_code_of_conduct branch from 2739f5d to 61bd8a9 Compare November 12, 2015 21:19
@eshellman
Copy link
Collaborator

Thanks for adding this.

vhf added a commit that referenced this pull request Nov 17, 2015
@vhf vhf merged commit a52a4eb into master Nov 17, 2015
@vhf vhf deleted the add_code_of_conduct branch December 14, 2015 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👥 discussion This Repo is guided by its community! Let's talk!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants