Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

courses-ko update #11164

Merged
merged 5 commits into from
Jun 25, 2024
Merged

courses-ko update #11164

merged 5 commits into from
Jun 25, 2024

Conversation

maldron0309
Copy link
Contributor

What does this PR do?

Add resource(s) | Remove resource(s) | Add info | Improve repo
Improve repo

For resources

Description

I've revised authors to match the guide, added new lessons, and deleted lessons that no longer work.

Why is this valuable (or not)?

I've modified it to match the guide.

How do we know it's really free?

yes

For book lists, is it a book? For course lists, is it a course? etc.

course

Checklist:

  • Read our contributing guidelines.
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction).
  • Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

Copy link

Linter failed, fix the error(s):

free-programming-books/courses/free-courses-ko.md
  110:1-112:3  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint
249:1-251:106  warning  Alphabetical ordering: swap l.250 and l.249                            alphabetize-lists  remark-lint
249:1-251:106  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

@github-actions github-actions bot added the linter error Please, correct build errors found by linter! label Jun 24, 2024
Copy link

Linter failed, fix the error(s):

free-programming-books/courses/free-courses-ko.md
249:1-251:106  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

@github-actions github-actions bot removed the linter error Please, correct build errors found by linter! label Jun 24, 2024
Copy link
Collaborator

@eshellman eshellman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big improvement!
It's easier to review if you make one type of change at a time. In this case everything looks fine except I think we need to keep the access note, and when the course platform is other than youtube, we want to give the name of the platform in parentheses:
* [title](link) - instructor or creator (platform if not youtube) (access note if needed)

courses/free-courses-ko.md Outdated Show resolved Hide resolved
@eshellman eshellman merged commit a365f20 into EbookFoundation:main Jun 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants