Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix grammar in code_of_conduct-id.md #10765

Merged
merged 17 commits into from
Nov 22, 2023
Merged

Conversation

prammmoe
Copy link
Contributor

@prammmoe prammmoe commented Oct 25, 2023

What does this PR do?

Add resource(s) | Remove resource(s) | Add info | Improve repo

For resources

Description

Why is this valuable (or not)?

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Read our contributing guidelines.
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction).
  • Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@github-actions
Copy link

Linter failed, fix the error(s):

free-programming-books/courses/free-courses-id.md
  88:1-89:180  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint
 142:1-151:85  warning  Alphabetical ordering: swap l.151 and l.150                            alphabetize-lists  remark-lint
 142:1-151:85  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint
 426:1-428:67  warning  Alphabetical ordering: swap l.427 and l.426                            alphabetize-lists  remark-lint
433:1-437:127  warning  Alphabetical ordering: swap l.437 and l.436                            alphabetize-lists  remark-lint

@github-actions github-actions bot added the linter error Please, correct build errors found by linter! label Oct 25, 2023
@github-actions
Copy link

Linter failed, fix the error(s):

free-programming-books/courses/free-courses-id.md
  88:1-89:180  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint
115:1-119:143  warning  Alphabetical ordering: swap l.119 and l.118                            alphabetize-lists  remark-lint
 143:1-152:85  warning  Alphabetical ordering: swap l.152 and l.151                            alphabetize-lists  remark-lint
 143:1-152:85  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint
 427:1-429:67  warning  Alphabetical ordering: swap l.428 and l.427                            alphabetize-lists  remark-lint
434:1-438:127  warning  Alphabetical ordering: swap l.438 and l.437                            alphabetize-lists  remark-lint

@github-actions
Copy link

Linter failed, fix the error(s):

free-programming-books/courses/free-courses-id.md
  88:1-89:180  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint
115:1-119:143  warning  Alphabetical ordering: swap l.119 and l.118                            alphabetize-lists  remark-lint
 143:1-152:85  warning  Alphabetical ordering: swap l.152 and l.151                            alphabetize-lists  remark-lint
 143:1-152:85  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint
315:1-316:110  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint
405:1-405:139  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint
409:1-410:117  warning  Alphabetical ordering: swap l.410 and l.409                            alphabetize-lists  remark-lint
 428:1-430:67  warning  Alphabetical ordering: swap l.429 and l.428                            alphabetize-lists  remark-lint
435:1-439:127  warning  Alphabetical ordering: swap l.439 and l.438                            alphabetize-lists  remark-lint

@github-actions
Copy link

Linter failed, fix the error(s):

free-programming-books/courses/free-courses-id.md
116:1-120:143  warning  Alphabetical ordering: swap l.120 and l.119                            alphabetize-lists  remark-lint
317:1-318:110  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint
407:1-407:139  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint
411:1-412:117  warning  Alphabetical ordering: swap l.412 and l.411                            alphabetize-lists  remark-lint

@github-actions github-actions bot removed the linter error Please, correct build errors found by linter! label Oct 26, 2023
courses/free-courses-id.md Outdated Show resolved Hide resolved
courses/free-courses-id.md Outdated Show resolved Hide resolved
courses/free-courses-id.md Outdated Show resolved Hide resolved
courses/free-courses-id.md Outdated Show resolved Hide resolved
courses/free-courses-id.md Outdated Show resolved Hide resolved
@@ -405,6 +410,7 @@

### Rust

* [Belajar bahasa pemrograman Rust!](https://www.youtube.com/watch?v=1gRIAVwDlb4&pp=ygUMYmVsYWphciBydXN0) - Ngooding
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For youtube, we prefer "playlist" links and the name of the producer/creator. docs/CONTRIBUTING.md#platforms-and-access-notes

courses/free-courses-id.md Outdated Show resolved Hide resolved
@@ -15,7 +15,7 @@ Contoh perilaku partisipan yang tidak dapat diterima meliputi:

* Penggunaan bahasa atau citra seksual
* Serangan pribadi
* Trolling atau komentar yang menghina/menghujat
* Trolling atau komentar yang bersifat menghina/menghujat
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to keep issues separate

* [Belajar Terraform untuk Pemula](https://www.youtube.com/playlist?list=PL4SGTPmSY0qngs44Ssc0RHO9h4fmZ9JUb) - Giri Kuncoro


### TypeScript

* [Belajar Typescript Dasar Bahasa Indonesia](https://www.youtube.com/playlist?list=PLiuHSY2x882Z4NSJGNq0eB9Fz6tIx-CgO) - Imam Farisi
* [Belajar Typescript OOP Bahasa Indonesia](https://www.youtube.com/playlist?list=PLiuHSY2x882a-sLbdqZTtraO3cl0Clwg0) - Imam Farisi
* [Belajar TypeScript Untuk Pemula](https://www.youtube.com/playlist?list=PL-CtdCApEFH_LJt-fhYfMMgqxirSu6EKo) - Eko Kurniawan Khannedy, Programmer Zaman Now
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean to remove this

courses/free-courses-id.md Outdated Show resolved Hide resolved
@eshellman eshellman added the waiting for changes PR has been reviewed and changes/suggestions requested label Oct 27, 2023
Copy link

Linter failed, fix the error(s):

free-programming-books/courses/free-courses-id.md
431:1-433:124  warning  Alphabetical ordering: swap l.433 and l.431  alphabetize-lists  remark-lint

@github-actions github-actions bot added the linter error Please, correct build errors found by linter! label Nov 21, 2023
Copy link

Linter failed, fix the error(s):

free-programming-books/courses/free-courses-id.md
431:1-432:124  warning  Alphabetical ordering: swap l.432 and l.431  alphabetize-lists  remark-lint

Copy link

Linter failed, fix the error(s):

free-programming-books/courses/free-courses-id.md
401:1-402:166  warning  Alphabetical ordering: swap l.402 and l.401  alphabetize-lists  remark-lint
431:1-432:124  warning  Alphabetical ordering: swap l.432 and l.431  alphabetize-lists  remark-lint

Copy link

Linter failed, fix the error(s):

free-programming-books/courses/free-courses-id.md
401:1-402:166  warning  Alphabetical ordering: swap l.402 and l.401  alphabetize-lists  remark-lint
431:1-432:124  warning  Alphabetical ordering: swap l.432 and l.431  alphabetize-lists  remark-lint

Copy link

Linter failed, fix the error(s):

free-programming-books/courses/free-courses-id.md
400:1-401:166  warning  Alphabetical ordering: swap l.401 and l.400  alphabetize-lists  remark-lint
430:1-431:124  warning  Alphabetical ordering: swap l.431 and l.430  alphabetize-lists  remark-lint

Copy link

Linter failed, fix the error(s):

free-programming-books/courses/free-courses-id.md
 143:1-152:91  warning  Alphabetical ordering: swap l.148 and l.147  alphabetize-lists  remark-lint
400:1-401:166  warning  Alphabetical ordering: swap l.401 and l.400  alphabetize-lists  remark-lint
430:1-431:124  warning  Alphabetical ordering: swap l.431 and l.430  alphabetize-lists  remark-lint

Copy link

Linter failed, fix the error(s):

free-programming-books/courses/free-courses-id.md
 143:1-152:91  warning  Alphabetical ordering: swap l.148 and l.147  alphabetize-lists  remark-lint
400:1-401:166  warning  Alphabetical ordering: swap l.401 and l.400  alphabetize-lists  remark-lint
430:1-431:124  warning  Alphabetical ordering: swap l.431 and l.430  alphabetize-lists  remark-lint

@@ -113,6 +114,7 @@
### Docker

* [Belajar Docker untuk Pemula](https://www.youtube.com/playlist?list=PL4SGTPmSY0qkxCTe3Gd0wA-bQZChXhsNI) - Giri Kuncoro
* [Belajar Membuat CI/CD Pipeline Aplikasi TypeScript dengan Gitlab + Docker](https://youtu.be/Sy_Uay0fxlg?si=lSKE6ux9nyfUC22X) - Iqbal Syamil
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [Belajar Membuat CI/CD Pipeline Aplikasi TypeScript dengan Gitlab + Docker](https://youtu.be/Sy_Uay0fxlg?si=lSKE6ux9nyfUC22X) - Iqbal Syamil

Copy link

Linter failed, fix the error(s):

free-programming-books/courses/free-courses-id.md
 143:1-152:91  warning  Alphabetical ordering: swap l.148 and l.147  alphabetize-lists  remark-lint
400:1-401:166  warning  Alphabetical ordering: swap l.401 and l.400  alphabetize-lists  remark-lint

@github-actions github-actions bot removed the linter error Please, correct build errors found by linter! label Nov 22, 2023
@eshellman eshellman merged commit b8031a9 into EbookFoundation:main Nov 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for changes PR has been reviewed and changes/suggestions requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants