Skip to content

Conversation

@Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Oct 4, 2023

Description

Testing

Ran these added commands in the repl to make sure these work as expected.

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested a review from a team October 4, 2023 17:39
Copy link

@dcaballeroc dcaballeroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test might come in handy

@Justintime50
Copy link
Member Author

A test might come in handy

I tested in the repl before pushing up, troubles with a test like this is we can't guarantee timezones of whatever machine it'll run on. Depending on CI or someones local machine, default timezones may differ and assertions wouldn't necessarily match

@dcaballeroc
Copy link

A test might come in handy

I tested in the repl before pushing up, troubles with a test like this is we can't guarantee timezones of whatever machine it'll run on. Depending on CI or someones local machine, default timezones may differ and assertions wouldn't necessarily match

Timezones: not even once.

@Justintime50 Justintime50 merged commit 7d3b903 into master Oct 4, 2023
@Justintime50 Justintime50 deleted the reset_timezone branch October 4, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Timezone is changed and not changed back

5 participants