feat: adds http request and response hooks #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwithan8
approved these changes
Jul 17, 2023
jchen293
reviewed
Jul 18, 2023
Contributor
jchen293
left a comment
jchen293
left a comment
There was a problem hiding this comment.
lgtm, left a few non-blocking comments
jchen293
approved these changes
Jul 18, 2023
Contributor
jchen293
left a comment
jchen293
left a comment
There was a problem hiding this comment.
I meant to approve this with my previous comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RequestHookandResponseHookevents. (un)subscribe to them with the newsubscribeToRequestHook,subscribeToResponseHook,unsubscribeFromRequestHook, orunsubscribeFromResponseHookmethods of anEasyPostClientTesting
Adds a new set of tests that subscribe to the hooks and assert details only exposed via the hooks (not the traditional deserialized objects)
Adds a test to ensure that unsubscribing works as intended (will raise an exception if still subscribed), A/B tested this to ensure it works.
Pull Request Type
Please select the option(s) that are relevant to this PR.