Skip to content

Conversation

@Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Sep 21, 2022

Description

Removes some unreachable address verification code. If an error occurs during verification, we will fail earlier than this function in the stack (closer to the request) and therefore we don't need to check for the existence of the address key. I added a unit test to ensure that we still properly throw error when an invalid address is passed meaning this change doesn't affect user expectations.

Testing

Added a unit test for throwing errors on invalid address verifications

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested a review from a team September 21, 2022 16:02
@Justintime50 Justintime50 merged commit 6ab30f2 into master Sep 21, 2022
@Justintime50 Justintime50 deleted the simpler_address_verify branch September 21, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants