Added missing return-statement in DefaultConfiguration. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daFish nice catch! I was making changes on this up to the very last minute :) Thanks for fixing it. |
javiereguiluz
added a commit
that referenced
this pull request
May 26, 2017
This PR was merged into the 1.0.x-dev branch. Discussion ---------- Added missing return-statement in DefaultConfiguration. This adds `return $this` to the `fixPermissionsWith*`-methods which were missing previously. Commits ------- 5d6c0ca Added missing return-statement in DefaultConfiguration.
|
@javiereguiluz You're very welcome. Glad I can help making this great bundle even more useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
return $thisto thefixPermissionsWith*-methods which were missing previously.