Repository navigation
Make all methods protected, not private #72
Description
Activity
You can implement your own deployer class by extending
EasyCorp\Bundle\EasyDeployBundle\Deployer\AbstractDeployer. This way you have complete control over each method you need to customize.While that's true, if I only want to change one method from the DefaultDeployer, then why rewrite the whole class?
What's the reason for wanting to keep the methods private?
The DefaultDeployer has a load of useful methods and it would be great to keep them.
Reacted by maxkainThe reason is the "open-closed-principle" which states that classes should be open for extension but closed for modification.
To make this happen more extension points are needed. Unless they are provided, you have limited options:
- implement your own deployer class
- fork this repo, modify it to your use, and you it
Opting for the latter would also mean more maintenance at your side.
The reason is the "open-closed-principle" which states that classes should be open for extension but closed for modification.
To make this happen more extension points are needed. Unless they are provided, you have limited options:
* implement your own deployer class * fork this repo, modify it to your use, and you it Opting for the latter would also mean more maintenance at your side.The extension point is protected method. The original class is not modifying. The principle is not violated.
Anyway, the application developer may decide how to do it by himself and the private method limits him. The bundle should give developer possibilities, but it should not dictate him how to write his code.
Hi there,
I've been using your deployer for a while now and its fantastic - but it would be great to make all of the methods in the DefaultDeployer protected instead of private - that way we can easily override them if we need to.
For example, I was having trouble with the doResetOpCache function.
Inserting a 1 second sleep between writing the file and wgetting the file has solved this problem, but I cannot override the class method!
Thanks!