Conversation
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies, including zarrita to version 0.7.x, rollup to 4.60.1, and unzipit to 2.0.0, while also removing the yaml package. Feedback was provided to restrict the peerDependencies range for zarrita to ^0.7.0 in both package.json and package-lock.json to prevent potential version mismatches and incompatibilities due to breaking changes in the 0.7.x release.
| }, | ||
| "peerDependencies": { | ||
| "zarrita": "^0.5.0 || ^0.6.0" | ||
| "zarrita": "^0.5.0 || ^0.6.0 || ^0.7.0" |
There was a problem hiding this comment.
As noted in the pull request description, zarrita 0.7.x introduces breaking changes compared to 0.5.x and 0.6.x. If the code has been updated to be compatible with 0.7.x, it is highly likely that it is no longer compatible with the older versions. You should remove ^0.5.0 || ^0.6.0 from peerDependencies to prevent users from installing this package with incompatible versions of zarrita.
| "zarrita": "^0.5.0 || ^0.6.0 || ^0.7.0" | |
| "zarrita": "^0.7.0" |
package-lock.json
Outdated
| }, | ||
| "peerDependencies": { | ||
| "zarrita": "^0.5.0 || ^0.6.0" | ||
| "zarrita": "^0.7.1" |
There was a problem hiding this comment.
There is a mismatch between the peerDependencies range in package.json (^0.5.0 || ^0.6.0 || ^0.7.0) and the one recorded here in package-lock.json (^0.7.1). These should be kept in sync. Following the suggestion to restrict the range in package.json to ^0.7.0, this entry should also be updated to match.
| "zarrita": "^0.7.1" | |
| "zarrita": "^0.7.0" |
tests were passing locally, although admittedly probably we should only keep 0.7? since this is definitely breaking as compared to 0.6 and 0.5.