[WIP] LSTM in GenericHybridModel #217
Draft
+832
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…indow = time in KeyedArrays and DimArrays
lazarusA
reviewed
Dec 27, 2025
| # DimensionalData | ||
| mat = Array(Matrix(dfnot)') | ||
| da = DimArray(mat, (Dim{:col}(Symbol.(names(dfnot))), Dim{:row}(1:size(dfnot, 1)))) | ||
| da = to_dimArray(dfnot) |
Member
There was a problem hiding this comment.
please undo the changes to this to avoid conflicts with my other PR. I'm moving this to the documentation.
lazarusA
reviewed
Dec 27, 2025
|
|
||
| docstring = """ | ||
| $(name)(NN, predictors, forcing, targets$(isempty(param_syms) ? "" : ", " * join(string.(param_syms), ", "))) | ||
Member
There was a problem hiding this comment.
your editor is somehow touching other files, without real changes.
Collaborator
Author
There was a problem hiding this comment.
Not sure when it came in - I suspect the formatting script
lazarusA
reviewed
Dec 27, 2025
| _select_time(ŷ_t::KeyedArray, time_keys) = ŷ_t(time = time_keys) # KeyedArray: () syntax - view & differentiable | ||
| _select_time(ŷ_t::AbstractDimArray, time_keys) = ŷ_t[time = At(time_keys)] # DimArray: [] syntax - copy & differentiable | ||
|
|
||
| function assemble_loss(ŷ, y::Union{KeyedArray{T, 3}, AbstractDimArray{T, 3}}, y_nan, targets, loss_spec) where {T} |
Member
There was a problem hiding this comment.
my original thinking for assemble_loss was to have only one, a generic function, and delegate/multidispatch on use cases to inner functions, such as _get_target_y, etc. We can come back to this later, once things work as expected.
lazarusA
reviewed
Dec 27, 2025
lazarusA
reviewed
Dec 27, 2025
| df = load_timeseries_netcdf("https://github.com/bask0/q10hybrid/raw/master/data/Synthetic4BookChap.nc") | ||
|
|
||
| # Select a subset of data for faster execution | ||
| df = df[1:20000, :] |
Member
There was a problem hiding this comment.
Suggested change
| df = df[1:20000, :] | |
| df = df[1:20000, :] | |
| first(df, 5) |
same reason here. You get the gist 😄 .
Co-authored-by: Lazaro Alonso <lazarus.alon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plotting = false