Skip to content

provide type hints in optimize #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bgctw merged 1 commit into from
Nov 1, 2023
Merged

provide type hints in optimize #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/optimizer.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,12 @@ function optimize(f, ::NotSetOptimizer, lower, upper)
end

df_optimizer = NotSetOptimizer();
optimize(f, lower, upper) = optimize(f, df_optimizer, lower, upper)
function optimize(f, lower::T, upper::T) where T
ans = optimize(f, df_optimizer, lower, upper)
# since df_optimizer is global, the returntype of optimize is not inferred
# provide type hints for minizer and converged, but provide full answer in NamedTuple
minimizer = ans.minimizer::T
converged = ans.converged::Bool
(;minimizer, converged, ans)
end
set_optimizer(opt::AbstractDistributionFitOptimizer) = (global df_optimizer = opt)