Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Earth sci ml basev10 #43

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Earth sci ml basev10 #43

merged 2 commits into from
Jul 18, 2024

Conversation

jialinl6
Copy link
Contributor

Update docs, src, and tests to be compatible with EarthSciMLBase.jl version 1.10 and GasChem.jl version 0.6

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.95%. Comparing base (226004d) to head (7b7f405).
Report is 5 commits behind head on main.

Files Patch % Lines
ext/GasChemExt.jl 86.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #43      +/-   ##
===========================================
- Coverage   100.00%   98.95%   -1.05%     
===========================================
  Files            5        5              
  Lines          181      192      +11     
===========================================
+ Hits           181      190       +9     
- Misses           0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ctessum ctessum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ctessum ctessum merged commit be7a414 into EarthSciML:main Jul 18, 2024
3 of 6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants