TakeProfit in mode Pips varies with Entry Price

[samuelion]

Hello !

I am very sorry to bother you again ^^".
I am starting to use Position Sizer and see some weird behavior so I prefer to share them to you for analysis.

I guess in UpdateTakeProfitsFromEntryPriceChanged, the final else should update Pips only if TakeProfits.Mode == TargetMode.Price, and should update price otherwise.
Currently, Pips is always update, and when TakeProfits.Mode == TargetMode.Pips, the behavior is I think not what is expected.

thanks for your help =).
Have a nice day.

[aamoraru]

Could you please explain what exactly you are doing and what happens?

[samuelion]

Basically, if I put SL at 200pips, the value remains fixed here at 200pips.
If I put TP to 200pips, the TP value changes quite often (many times per minutes) and it goes away from my target. I can't find a way to have it sticked to 200pips.

If you are not in a hurry, I'll do a precise and concrete test tonight to describe exactly test, what I got and even Logs if needed.

[aamoraru]

Is the TP set to points or to a price level? Do you have the Lock checkbox ticked?

[samuelion]

I reproduced it right now in a basic setup.
=> Cbot V1.22
=> Start (all parameters are to default values)
=> Shift + P to put TP in points.
=> Set a random TP value, let's say 100 points
=> The TP points move on its own

• Lock checkbox untouched (and disabled by default).

As I said, UpdateTakeProfitsFromEntryPriceChanged has 3 branches, 1 test TakeProfits.Mode and second set TP.Price and Pips from ATR regardless any user TP param, only the last else has a single behavior (set Pips from Price) regardless of TakeProfits.Mode value (and I think this is not wanted, in Pips mode, we want to set Price from Pips and not the other one).

On a local version (not the one tested), I added : in the else something like this
if (TakeProfits.Mode == TargetMode.Price)
/* here your code already existing */
else
{
takeProfit.Price = takeProfit.Pips == 0
? 0
: TradeType == TradeType.Buy
? EntryPrice + takeProfit.Pips * Symbol.PipSize
: EntryPrice - takeProfit.Pips * Symbol.PipSize;
}

Not sure testing Pips to 0 is needed, it was just to mimic the setting of Pips from Price in the if branch.

Maybe I am completely mistaken though, just check and judge =).
Regards.

[aamoraru]

Thanks! Now I understand what the problem is. This too will be fixed in the next release.